瀏覽代碼

i2c: Fix pca953x endianess issue

By reading 2 consecutive bytes from i2c to an u16 value
we have an endianess issue.

Signed-off-by: Dirk Eibach <dirk.eibach@gdsys.cc>
Dirk Eibach 9 年之前
父節點
當前提交
daa75b3482
共有 1 個文件被更改,包括 3 次插入1 次删除
  1. 3 1
      drivers/gpio/pca953x.c

+ 3 - 1
drivers/gpio/pca953x.c

@@ -88,8 +88,10 @@ static int pca953x_reg_write(uint8_t chip, uint addr, uint mask, uint data)
 		if (i2c_read(chip, addr << 1, 1, (u8*)&valw, 2))
 		if (i2c_read(chip, addr << 1, 1, (u8*)&valw, 2))
 			return -1;
 			return -1;
 
 
+		valw = le16_to_cpu(valw);
 		valw &= ~mask;
 		valw &= ~mask;
 		valw |= data;
 		valw |= data;
+		valw = cpu_to_le16(valw);
 
 
 		return i2c_write(chip, addr << 1, 1, (u8*)&valw, 2);
 		return i2c_write(chip, addr << 1, 1, (u8*)&valw, 2);
 	}
 	}
@@ -107,7 +109,7 @@ static int pca953x_reg_read(uint8_t chip, uint addr, uint *data)
 	} else {
 	} else {
 		if (i2c_read(chip, addr << 1, 1, (u8*)&valw, 2))
 		if (i2c_read(chip, addr << 1, 1, (u8*)&valw, 2))
 			return -1;
 			return -1;
-		*data = (int)valw;
+		*data = (uint)le16_to_cpu(valw);
 	}
 	}
 	return 0;
 	return 0;
 }
 }