Browse Source

x86: Add comments to the SIPI vector

The Intel SIPI (start-up inter-processor interrupt) vector is the entry
point for each secondary CPU (also called an AP - applications processor).
The assembler and C code are linked, so add comments to indicate this.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Simon Glass 9 years ago
parent
commit
d116b53f87
2 changed files with 2 additions and 0 deletions
  1. 1 0
      arch/x86/cpu/sipi_vector.S
  2. 1 0
      arch/x86/include/asm/sipi.h

+ 1 - 0
arch/x86/cpu/sipi_vector.S

@@ -193,6 +193,7 @@ load_msr:
 	mov	c_handler, %esi
 	call	*%esi
 
+	/* This matches struct sipi_param */
 	.align	4
 .globl	sipi_params
 sipi_params:

+ 1 - 0
arch/x86/include/asm/sipi.h

@@ -42,6 +42,7 @@ struct __packed sipi_params_16bit {
  * struct sipi_params - 32-bit SIP entry-point parameters
  *
  * These are used by the AP init code and must be set up before the APs start.
+ * The members must match with the sipi_params layout in sipi_vector.S.
  *
  * The stack area extends down from @stack_top, with @stack_size allocated
  * for each AP.