Эх сурвалжийг харах

microblaze: Fix watchdog initialization

The patch:
"blackfin: Move blackfin watchdog driver out of the blackfin arch folder."
(sha1: e9a389a18477c1c57a0b30e9ea8f4d38c6e26e63)
changed hw_watchdog_init() prototype which didn't match
with Microblaze one.
This patch fixes the driver and Microblaze initialization.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Michal Simek 11 жил өмнө
parent
commit
8c4dba1a5e

+ 0 - 1
arch/microblaze/include/asm/processor.h

@@ -16,7 +16,6 @@ extern char __text_start[];
 void board_init(void);
 
 /* Watchdog functions */
-extern int hw_watchdog_init(void);
 extern void hw_watchdog_disable(void);
 
 #endif /* __ASM_MICROBLAZE_PROCESSOR_H */

+ 3 - 3
arch/microblaze/lib/board.c

@@ -46,9 +46,6 @@ init_fnc_t *init_sequence[] = {
 	serial_init,
 	console_init_f,
 	interrupts_init,
-#ifdef CONFIG_XILINX_TB_WATCHDOG
-	hw_watchdog_init,
-#endif
 	timer_init,
 	NULL,
 };
@@ -97,6 +94,9 @@ void board_init_f(ulong not_used)
 
 	serial_initialize();
 
+#ifdef CONFIG_XILINX_TB_WATCHDOG
+	hw_watchdog_init();
+#endif
 	for (init_fnc_ptr = init_sequence; *init_fnc_ptr; ++init_fnc_ptr) {
 		WATCHDOG_RESET();
 		if ((*init_fnc_ptr) () != 0)

+ 2 - 4
drivers/watchdog/xilinx_tb_wdt.c

@@ -54,7 +54,7 @@ static void hw_watchdog_isr(void *arg)
 	hw_watchdog_reset();
 }
 
-int hw_watchdog_init(void)
+void hw_watchdog_init(void)
 {
 	int ret;
 
@@ -65,7 +65,5 @@ int hw_watchdog_init(void)
 	ret = install_interrupt_handler(CONFIG_WATCHDOG_IRQ,
 						hw_watchdog_isr, NULL);
 	if (ret)
-		return 1;
-
-	return 0;
+		puts("Watchdog IRQ registration failed.");
 }