Bläddra i källkod

fw_printenv: Fix crash due to incorrect size for malloc'ed string.

Using sizeof gives the size of the pointer only, not the string. This
could easily lead to crashes when using -l argument.

Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
Kristian Amlie 7 år sedan
förälder
incheckning
8a0b827b1a
1 ändrade filer med 1 tillägg och 1 borttagningar
  1. 1 1
      tools/env/fw_env_main.c

+ 1 - 1
tools/env/fw_env_main.c

@@ -239,7 +239,7 @@ int main(int argc, char *argv[])
 	argv += optind;
 
 	if (env_opts.lockname) {
-		lockname = malloc(sizeof(env_opts.lockname) +
+		lockname = malloc(strlen(env_opts.lockname) +
 				sizeof(CMD_PRINTENV) + 10);
 		if (!lockname) {
 			fprintf(stderr, "Unable allocate memory");